Some query class / unit tests fixes and enhancements #4163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, make the test data slightly more interesting by varying Position values for the clips/transitions in the test data.
By calling get_app() each time we need to access the project data, we delay the lookup until it's needed. As a result, query classes can now be imported even if an application instance has not been initialized.
ferdnyc
commented
Jun 29, 2021
- Rename the `TestQueryClass` class to `QueryTests`, which is more in keeping with unittest norms. - Replace all explicit uses of `TestQueryClass` throughout the code with `cls` or `self` as appropriate, to eliminate friction against any future name changes.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My ambitious PRs tend to sit for months on end with no review, often becoming so divergent from the target branch that the conflicts are unresolvable. As a result, I'm trying to submit more, smaller PRs. This is one, containing a first round of tweaks to the project-data query classes and their associated unit tests.
filter(intersect=)Also, make the test data slightly more interesting by varying
Positionvalues for the clips/transitions in the test data.app.projectBy calling
get_app()each time we need to access the project data, we delay the lookup until it's needed. As a result, query classes can now be imported even if an application instance has not yet been initialized. (As long as it's initialized before the first call to a query class method).(There's no longer any need to delay the imports.)
TestQueryClassclass toQueryTests, which is more in line with typicalunittestnamingTestQueryClassreferences in the class code withclsorselfas appropriate, so any future renaming will be far less of a pain