Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate the Ubuntu Unity integration #3937

Merged
merged 2 commits into from
Dec 27, 2020
Merged

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Dec 26, 2020

I honestly don't think the Unity progress-bar integration was working even on Ubuntu anymore, but turns out now it's also causing crashes on Fedora 33 when Python tries to import gi.

This PR rips out the Unity integration, and moves the export-progress signals from main_window to export as they're now only used locally.

It also removes an aboutToQuit signal connection I had added, which is causing double unsaved-project prompts on exit if you say "No" to the first one.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Dec 27, 2020

Going to merge this as well. There's some possibility that the Unity integration is still useful to people, so its removal might impact them, but it's a non-critical piece of functionality. (Worst case, a progress bar is no longer displayed on the application icon during export — that's the only thing lost here. Assuming it even worked.)

We could certainly restore it, with a better implementation. But preventing full-on crashes (on some non-Ubuntu systems) during export trumps the convenience of a progress bar.

@ferdnyc ferdnyc merged commit 5056d24 into OpenShot:develop Dec 27, 2020
@ferdnyc ferdnyc deleted the no-unity branch December 27, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant