Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #3909, it turns out my use of a
defaultdict
in the credits model wasn't practical, because the input data file explicitly containsnull
values, which get converted intoNone
on JSON import. If a dict contains explicitNone
values, it will return them when those keys are dereferenced, ignoring the type set for thedefaultdict
.So, I scrapped the
defaultdict
, wrote a loop to scrub out anyNone
keys, and protected all of the accesses toperson
keys by usingperson.get()
.Eliminates tracebacks when viewing credits, and fixes text filtering in the credits views.