Skip to content

Solve bug: Credits window not popping up #3909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2020
Merged

Solve bug: Credits window not popping up #3909

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de3e151
Solved bug: Credits window (Help > About OpenShot > Credits) was not …
KilianMaes Dec 9, 2020
2d5e75a
Resolve Credits not popping up bug: minor changes
KilianMaes Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/windows/models/credits_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def update_model(self, filter=None, clear=True):

for person in self.credits_list:
# Get details of person
data = defaultdict("")
data = defaultdict(str)
data.update({
"name": person.get("name"),
"email": person.get("email"),
Expand All @@ -82,7 +82,7 @@ def update_model(self, filter=None, clear=True):
# Append type icon (PayPal, Kickstarter, Bitcoin, or Patreon)
item = QStandardItem()
for contrib in [n for n in self.icon_mapping if n in data["icons"]]:
(icon, tooltip) = self.icon_mapping.get(contrib, (None, None))
(tooltip, icon) = self.icon_mapping.get(contrib, (None, None))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're quite right about that, good catch!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

item.setIcon(icon)
item.setToolTip(tooltip)
item.setFlags(flags)
Expand Down