"Copy Keyframes > All" includes "Crop *" settings #3898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Feel free to ignore this PR or tell me i'm out of my mind) But this may help someone who maybe expecting the Copy Keyframes > All feature to include the Crop keyframes (which work together with scaling X/Y and location X/Y to "frame" a video nicely). Added data elements in my proposal: -`crop_x` -`crop_y` -`crop_height` -`crop_width` Tested it locally and seems to work. Not sure if there is a catch. Again, please just tell me if there is. Hope this helps
|
@spt3m4 Thanks! Yeah, weird that those weren't included. There are still a bunch of others missing, actually — really seems like "All" should include all of them. We should probably change the approach entirely, instead of relying on a hardcoded list. But until that's done, we have what we have. Now at least Crop will be covered as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Feel free to ignore / reject this PR or tell me i'm out of my mind)
But this may help someone who maybe expecting the Copy Keyframes > All feature to include the Crop keyframes (which work together with scaling X/Y and location X/Y to "frame" a video nicely).
Added data elements during copy in my proposal:
-
crop_x-
crop_y-
crop_height-
crop_widthTested it locally and seems to work. Not sure if there is a catch. Again, please just tell me if there is.
Hope this helps