Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title templates: Make all transparent backgrounds black #3814

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Nov 1, 2020

As a follow-on to #3813 and the issues I brought up there, this PR modifies the source of all of our title template SVGs, and sets the background fill color to #000 on all of the templates with a fully transparent background.

In theory, the background color doesn't matter when it's fully transparent, but it does matter in terms of how the color-change button is shown and what shows in the color picker, and this is much more representative of what you'll actually see.

(This change also won't affect Inkscape, It still shows a white background by default, or a checkerboard background if checkerboard transparency is turned on for the file.)

@ferdnyc ferdnyc added the interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...) label Nov 1, 2020
@ferdnyc
Copy link
Contributor Author

ferdnyc commented Nov 1, 2020

With this change (but without #3813), the same Title Editor template I used for my screenshots there:

Screenshot from 2020-11-01 09-06-02

And, how it shows in the regular QColorPicker:

Screenshot from 2020-11-01 09-06-07

(But it's still misleading, because if you change that color it will still have no effect unless you raise the alpha level.)

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Nov 2, 2020

Also merging this, as it's purely a perception thing and I can't even fathom someone arguing that the white transparent backgrounds our templates currently have is deliberate or useful in some way. It's just that nobody ever got around to changing it. Until now.

@ferdnyc ferdnyc merged commit b904b5c into OpenShot:develop Nov 2, 2020
@ferdnyc ferdnyc deleted the black-title-backgrounds branch November 2, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant