Skip to content

Blender: Make color-picker dialog non-modal #3805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Oct 29, 2020

The "Pick a screen color" feature isn't too useful if you can't move the dialog out of the way of the rest of the interface.

Fixes #3799

The "Pick a screen color" feature isn't too useful if you can't move
the dialog out of the way of the rest of the interface.
@ferdnyc ferdnyc added interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...) closer This PR fixes one or more reported Issues labels Oct 29, 2020
@ferdnyc
Copy link
Contributor Author

ferdnyc commented Oct 29, 2020

Hmm. It does strike me now that it might make sense to do the same thing for the non-animated Titles dialog, as well.

@jonoomph
Copy link
Member

Nice, that makes sense! Thanks!

@jonoomph jonoomph merged commit 4d41fd2 into OpenShot:develop Oct 29, 2020
@ferdnyc
Copy link
Contributor Author

ferdnyc commented Oct 31, 2020

@jonoomph

*nod* I've now concluded we should do the same thing for both the regular Title Editor, and any of the color Properties values, for the exact same reason. The "eyedropper" functionality is useless if you can't reach the rest of the application's UI.

I'll pull this out into a separate module under windows/ at some point and share the love.

@ferdnyc ferdnyc deleted the non-modal-color branch October 31, 2020 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closer This PR fixes one or more reported Issues interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color picker blocks the render view
2 participants