Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile: Seek to first frame on change #3795

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Oct 27, 2020

Visually, changing the project profile resets the playhead marker back to the start of the timeline. But the preview player was retaining the old position, causing subsequent operations to be performed in the wrong place. Now, we Seek() the player back to frame 1 as well.

Fixes #3119

@ferdnyc ferdnyc added closer This PR fixes one or more reported Issues interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...) labels Oct 27, 2020
@jonoomph
Copy link
Member

LGTM!

@jonoomph jonoomph merged commit d7db9f0 into OpenShot:develop Oct 29, 2020
@ferdnyc ferdnyc deleted the playhead-reset branch January 7, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closer This PR fixes one or more reported Issues interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing project profile moves playhead back to start of Timeline, but doesn't update position
2 participants