Fix "Add track" action (toolbar icon, keyboard shortcut) #3700
Conversation
- Seems if(layer_elem) will always be true, even when it refers to an unknown element that doesn't have an offset() method.
ferdnyc
added
the
interface
|
Hrm. Travis is doing that thing again where one of the two builds for the PR goes out to lunch and never comes back. If I visit the Travis CI website, the job is completed and successful. But the Github Actions interface never notices, and there's no way I can see to tell it, "Check again." (In fact, if I forcibly restart the job, the same thing will happen again.) Adding a commit to the PR nearly always fixes it, but that's a pain and we shouldn't have to. I need to open a bug report with them. |
|
I only just today noticed a critical data point about this problem, and have documented it to the Travis support forum. Now we wait... |
|
I also noticed that my fork still had an old Webhook from travis-ci.org installed on it, so I removed that. I'm wondering if maybe the same thing might be true on the OpenShot repo end. Time to email @jonoomph ... |
- Avoids hanging the UI on exit waiting for them to release
|
Stuffed in a totally unrelated, but good-to-have, change to unstick the build. |
|
LGTM! Merge away! |
Seems I tried to get too clever with Python iterators.
Also squashes a bug I hit in the JS
updateLayerIndeximplementation.Fixes #3696