-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project Files: Recursive folder import (drag-and-drop only) #3630
Conversation
44e0457
to
1bc2454
Compare
Grrr. Everything was all set, then I went back to fix a few totally preexisting things that got flagged in the code, and a bunch of unrelated stuff snuck in that broke everything. That's what I get for revising on the fly. |
@ferdnyc What is the merge status of this one? |
This looks really cool, I would love to get it merged, if it's ready. |
I resolved the conflicts on this one, but I'll let @ferdnyc merge this one, once you feel it's ready. 👍 |
Good question, I haven't looked at this in MONTHS TBH. I'll take a look after I deal with the timer PR. I agree, it'd be nice to get in there. (Just wish I had a good way of making it also work for File-menu type imports.) |
Glad I checked this again, caught one dumb typo. Will merge as soon as Travis gives the OK. |
Not too long ago (#3492), @CPUhead said, "I can't drag folders to the playlist". Well, now you can!
When processing drag-and-drop imports, OpenShot will recurse into any directories it finds, attempting to import all contained media. A few quirks of this mode:
.osp
file in with other media, but I imagine it won't be pretty. Just don't do that.os.walk
are all over the place and it was screwing up the image sequence imports to start from weird numbers.QUrl
as well, hoping it would enable selection of folders for import that way, too — but at least on Linux with the GNOME Shell file-open dialog, that doesn't work. If you select a folder alone it will descend into it instead of opening it, and if you multiply-select folders and files together it simply refuses to accept the "Open" button click. So, that's a bummer. But I left theQUrl
changes, because there's some chance it may open up opportunities for importing from more types of shared/network sources, at least on some platforms. I'll be curious to see what it changes, if anything.Oh, and along the way I fixed the bug @leehockhin reported in #3554, about duplicate import attempts halting the import. Don't know how I missed that one.
Fixes #3492 fixes #3554 (and probably others)