Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docks submenu to View menu, to easily toggle dock visibility #3622

Merged
merged 3 commits into from
Oct 16, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Jul 23, 2020

The menu will contain all of the closable docks, with checkboxes showing which are visible/invisible, so they can be toggled conveniently.

Hopefully the list will be sorted in localized order. (I'm using dock.windowTitle() as the sort key, which should be the translated name, but I'm having Python do the sorting so I'm not sure it'll DTRT for the current interface language if it doesn't use English-language sorting rules.)

Also: A bunch of code cleanup/formatting in main_window.py, including the elimination of all * imports.

Fixes: #3620

- Wrap long lines
- Eliminate star-imports
- Remove unused variables
- Formatting tweaks
- Use any() and all() in conditionals
@ferdnyc ferdnyc force-pushed the mainwin-view-docks branch from a3c99cb to e5bcffc Compare July 23, 2020 22:58
@ferdnyc ferdnyc added the interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...) label Jul 23, 2020
@jonoomph
Copy link
Member

Looks great! I've resolved 2 conflicts, but I think it should be good to merge now!

@jonoomph jonoomph merged commit 2bae9d1 into OpenShot:develop Oct 16, 2020
@ferdnyc ferdnyc deleted the mainwin-view-docks branch January 7, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

My project files tab is missing
2 participants