MacOS Catalina Support + Notarization + GCC 8.4 #3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to get past some errors with @rpath and @executablepath caused by the hardened runtime)
jonoomph
commented
Jul 7, 2020
| echo "Code Sign App Bundle (deep)" | ||
| codesign -s "OpenShot Studios, LLC" "build/$OS_APP_NAME" --deep --force | ||
| codesign -s "OpenShot Studios, LLC" --force --deep --entitlements "installer/openshot.entitlements" --options runtime --timestamp=http://timestamp.apple.com/ts01 "build/$OS_APP_NAME" |
There was a problem hiding this comment.
Every single file must be signed. If I don't sign with --deep, I get errors on *.svg files and all sorts of other files. Also, this adds a hardened runtime, a signature with a timestamp (required for notarization), and some entitlements, required to allow our @rpath handling.
jonoomph
commented
Jul 7, 2020
| @@ -52,8 +53,11 @@ if [ -d "$OS_PATH/MacOS/python3.6" ]; then | |||
| mv "$OS_PATH/MacOS/python36.zip" "$OS_PATH/Resources/python36.zip"; ln -s "../../Resources/python36.zip" "$OS_PATH/MacOS/lib/python36.zip"; | |||
| fi | |||
|
|
|||
| echo "Loop through bundled files and sign all binary files" | |||
| find "build" \( -iname '*.dylib' -o -iname '*.so' \) -exec codesign -s "OpenShot Studios, LLC" --timestamp=http://timestamp.apple.com/ts01 --entitlements "installer/openshot.entitlements" --force "{}" \; | |||
There was a problem hiding this comment.
This re-signs all *.dylib and *.so files with a timestamp, since the --deep option ignores files that are already signed... and thus, forces a failed notarization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big changes to our Mac builder, including an upgrade to Catalina (10.15). This change was required due to new Gatekeeper changes on newer MacOS versions. Apple now requires all apps to be notarized, which involves many things, including a hardened runtime, more strict code signing, and entitlements. It also required a newer compiler than GCC 4.8 (our previous one), so I upgraded to GCC 8.4.
The openshot-qt changes are mostly related to notarization, and include: