Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement interlace export #3570

Merged
merged 6 commits into from
Oct 16, 2020
Merged

Conversation

eisneinechse
Copy link
Collaborator

So far only an export in an mov container of an mpeg2 encoded clip works.
Further work is needed.

It may be that only mpeg2 in a mov container can do this in
this version of ffmpeg.
bottom field first in interlace mode.
Much more work needed.
@SuslikV
Copy link
Contributor

SuslikV commented Jun 17, 2020

For what?

Interlace is only supported in a view codec in some containers and
as far as I could see the mov container only supports it with mpeg2.
The mkv container supports more resent codecs like mpeg4, h264 and
h265.
@eisneinechse
Copy link
Collaborator Author

This should fix
#2922

@SuslikV
Copy link
Contributor

SuslikV commented Jun 26, 2020

Isn't better to remove this feature completely? Someone said that there is 20 years of XXI century already gone.

@eisneinechse
Copy link
Collaborator Author

Short answer: No.
Longer:
There is even someone that wants it and we said it is there. We are no multinational company that screws people by selling them things and then delivering a subset.
We could of course streamline everything a little more, only export mpeg2 in a mov container with 720p at 24 fps ; that would make thing so much easier. And while we're at it let's ban the wheel, old technology.

@eisneinechse eisneinechse changed the title (WIP) Implement interlace export Implement interlace export Jul 7, 2020
@eisneinechse
Copy link
Collaborator Author

@ferdnyc This would be the interlace support we promised a long time ago.

@jonoomph
Copy link
Member

LGTM

@jonoomph jonoomph merged commit 6a12b00 into OpenShot:develop Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants