translations: Use OpenShot_locale.qm file names #3507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While OpenShot.locale.qm is supported by Qt, many packaging tools expect names to use _ separators, so our naming causes difficulties.
|
LGTM! I'm fixing the launchpad translation system right now, so it will produce the correct *.qrc file, and the correct file naming. I'll test this out in a moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While names of the form
OpenShot.locale.qmare supported by Qt, many packaging tools expect translations to use _ separators in the file naming, so our filenames cause some difficulties.This PR renames all
OpenShot.$LANG_$LOC.qmfiles toOpenShot_$LANG_$LOC.qm, and makes the necessary changes tolaunch.py,classes.info,classes.language, theopenshot_lang.qrcfile, and etc. to support the updated names.(External scripts — like anything that manages the Launchpad translations — may also have to be corrected, though. If it's not part of this repo, I haven't fixed it.)
We've been using a custom
find_lang.shscript in the RPM Fusion packaging for several years now, due to this naming issue. Issue #418 was the initial report of that problem, and while we worked around it, the naming was something I failed to completely correct in #1795.Fixes #418 (which should give you an idea of just how old this issue is)