A lot of code cleanup, in timeline_webview #3291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rewrap lines, reindent, fix spacing - Replace print() with log.info() - Eliminate unused imports, variables - No bare Excepts
- ELiminate 'prop_name' variables, which are unnecessarily obtuse - Get rid of 'translations' list, incorporate translated strings into regular flow of code - Reformat several long lists as item-per-line
Bad:
"strings (" + "like this" + ") being " + assembled() + " with
addition..."
Slightly better:
"strings (like this) being {} with...".format(assembled())
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
print()withlog.info()prop_namevariables, which are unnecessarily obtusetranslationslist, incorporate translated strings into regular flow of code(sometimes using tuples, to pair them with untranslated partners)
.format()to assemble JS calls