Allow *.osp project files to be imported as a Clip #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nown "media_type"'s. Trigger "has unsaved changes" when clearing history from a Project, so the user can immediately save the *.osp file without history.
👍 I added the same thing to the Export dialog at some point, too, so users would be reminded to commit their updated (Now I have to go back and fix things so it only sets the flag if the export path is different from the previous value. Because it's a bit annoying having to save every time you export, if you use the same output directory each time.) |
ferdnyc
reviewed
Mar 11, 2020
Comment on lines
+154
to
+156
| else: | ||
| # If neither set, just assume video | ||
| file_data["media_type"] = "video" |
There was a problem hiding this comment.
This exact same code is copypasted into files_treeview.py as well, it probably makes sense to keep them in sync. (Better would be to eliminate the redundancy, but short of that...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few misc things, but all related to my work on allowing *.osp files to be imported as a Clip, without deadlocking the system, or crashing anything. 😉
Related PR for
libopenshot: OpenShot/libopenshot#459