WIP: Package standard .desktop file in AppImage #3223
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TuxVinyards pointed out that the
.desktop
file in our AppImage doesn't contain theCategories=
line required for it to properly show up in application menus. It was also missing a bunch of other fields, because instead of using the standard file fromxdg/
, thebuild-server.py
script was generating its own abbreviated version.But reading over the code for
openshot-qt.wrapper
in the AppImage, it seems like we could just use the standard file — it rewrites theExec=
line anyway, when copying it into the user's applications directory.So, this PR is an experiment with just copying
xdg/org.openshot.OpenShot.desktop
into the AppImage, instead. (It's a branch in the project repo, so an AppImage will get generated by the builders.)(Hopefully) fixes #3222