Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Package standard .desktop file in AppImage #3223

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Feb 13, 2020

@TuxVinyards pointed out that the .desktop file in our AppImage doesn't contain the Categories= line required for it to properly show up in application menus. It was also missing a bunch of other fields, because instead of using the standard file from xdg/, the build-server.py script was generating its own abbreviated version.

But reading over the code for openshot-qt.wrapper in the AppImage, it seems like we could just use the standard file — it rewrites the Exec= line anyway, when copying it into the user's applications directory.

So, this PR is an experiment with just copying xdg/org.openshot.OpenShot.desktop into the AppImage, instead. (It's a branch in the project repo, so an AppImage will get generated by the builders.)

(Hopefully) fixes #3222

@ferdnyc ferdnyc force-pushed the appimage-desktop-file branch 2 times, most recently from 0a3b168 to 12ebda4 Compare February 13, 2020 16:00
@ferdnyc
Copy link
Contributor Author

ferdnyc commented Feb 13, 2020

Whoops, dropped a paren. Let's try that again...

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Feb 13, 2020

This PR also removes $(APPIMAGE_MOUNT)/usr/lib/mime/packages/openshot-qt, because:

  1. It contains a hardcoded /usr/bin/ path
  2. Nothing uses it, that I can find — on my (Fedora) system, it is the ONLY file in /usr/lib/mime/packages/
  3. Everything works just fine without it, as far as I can tell.

I'd really like to get rid of it entirely (including removing it from the setup.py-generated installs), but I'm using the AppImage as a proving ground since I'm almost certain that it's broken there even if it DOES work elsewhere.

@ferdnyc ferdnyc force-pushed the appimage-desktop-file branch from 12ebda4 to e21c149 Compare February 13, 2020 16:38
@ferdnyc ferdnyc changed the title Package standard .desktop file in AppImage WIP: Package standard .desktop file in AppImage Feb 13, 2020
@ferdnyc
Copy link
Contributor Author

ferdnyc commented Feb 13, 2020

First attempt failed miserably, not really sure why TBH. Trying again, but now rewriting the Exec= line on the way in.

Edit: That worked. Guess the Exec= line does matter!

@ferdnyc ferdnyc force-pushed the appimage-desktop-file branch from e21c149 to d193f79 Compare February 13, 2020 16:44
@ferdnyc
Copy link
Contributor Author

ferdnyc commented Feb 14, 2020

Going to merge this, so our AppImage .desktop file is generated with Categories and other goodness.

@ferdnyc ferdnyc merged commit e247a9b into develop Feb 14, 2020
@ferdnyc ferdnyc deleted the appimage-desktop-file branch February 14, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appimage .desktop file needs Categories=
1 participant