Skip to content

User title templates not preserved in 2.5.0/2.5.1 #3375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ferdnyc opened this issue Apr 13, 2020 · 5 comments · Fixed by #3376
Closed

User title templates not preserved in 2.5.0/2.5.1 #3375

ferdnyc opened this issue Apr 13, 2020 · 5 comments · Fixed by #3376
Labels
🐞 bug A bug, error, or breakage of any kind

Comments

@ferdnyc
Copy link
Contributor

ferdnyc commented Apr 13, 2020

Question: Why is it,if I save a custom footer/title template it is still in
the ~/honm/,openshot-qt/title folder even after program is closed,,,when I
open Openshot,all the saved templates are cleared out? I know I done this
in the past but i am thinking there may be like a 'custom' folder you have
to make within the openshot-qt folder.

Originally posted by @brcisna in OpenShot/libopenshot#474 (comment)

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Apr 13, 2020

Turns out, this is something we messed up during the move to _assets directories.

Previously, info.TITLE_PATH ($HOME/.openshot_qt/title) was the location for user title templates, and the actual generated titles were stored in the info.ASSETS_PATH (which just pointed to $HOME/.openshot_qt/).

That was certainly confusing and weird, so with the _assets directory change, generated titles moved to live in a titles subdirectory of the assets folder (or of the user settings dir, prior to project save), and the info.TITLE_PATH follows that location.

All well and good, but it means we accidentally lost the user template location. Looks like we need an info.USER_TITLES_PATH.

@ferdnyc ferdnyc added the 🐞 bug A bug, error, or breakage of any kind label Apr 13, 2020
@ferdnyc
Copy link
Contributor Author

ferdnyc commented Apr 15, 2020

@brcisna This fix is now merged, and the latest develop branch should include any SVG files placed in $HOME/.openshot_qt/title_templates/ in the Title Editor interface. (I had to change the location due to the repurposing of the .../title directory, but this new name is more indicative of its purpose anyway.)

@brcisna
Copy link

brcisna commented Jun 13, 2020 via email

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Jun 18, 2020

@brcisna Sorry, buried under a mountain of old messages.

To use custom .blend files in OpenShot, you'd need to install them directly into the package source, and you'd also need to write:

  1. A corresponding .py script that sets all of the parameters required by the .blend
  2. An XML definition for the user interface, which would define how those parameter values are presented to the user.

The structure of the Animated Title templates is quite complex, and not really intended to be user-extensible.

If you were to create all three of those elements, it definitely is user-extensible, but like I said it's not for the faint of heart. A .blend file alone does not an OpenShot animated title template make.

@brcisna
Copy link

brcisna commented Jun 19, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug A bug, error, or breakage of any kind
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants