Improved Caption Effect #899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…following fixes: - improved regex, which now detects lines without blank lines separating them, and detects captions that start with numbers - line wrapping fixed for languages that don't use spaces - forced line wrapping of long strings of characters
…. Also, allow the Caption effect to add image data (i.e. waveform graphic) and allow Clip to detect that image to output it correctly. The result of all this: audio-only files now support the Caption effect, on top of the generated waveform image. Lastly, generated waveforms should use the entire Timeline size - and not a pre-determined 720x480 size.
… by default (i.e. image sequences) - FFmpegReader info struct should not be initialized during Open() after it is initially populated - so our SetJson() method can properly override it's values - FrameMapper Json() method should include it's mapped Reader JSON - even though it is not yet possible to read it back in yet - New unit tests for Timeline ApplyJsonDiff, and verification that we can override FFmpegReader info struct (i.e. updating FPS, time bases, etc...) - Some whitespace fixes
…values for Windows and Linux unit tests, since fonts are rendering using different systems... and are not equal.
* Experimental test for unit tests without display * Ignore unit tests running on an invalid QT Platform (i.e. offscreen - running as a test on GitHub) * Fix whitespace on Caption effect * Check for env variable for QT_QPA_PLATFORM == offscreen, and ignore Caption unit tests (for GitHub checks)
Codecov Report
@@ Coverage Diff @@
## develop #899 +/- ##
===========================================
- Coverage 52.79% 52.70% -0.10%
===========================================
Files 189 190 +1
Lines 16605 16771 +166
===========================================
+ Hits 8767 8839 +72
- Misses 7838 7932 +94
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timelineframe size - instead of 720x480.%to use aFFmpegReader