Coverity 2025 #3438
Open
Coverity 2025 #3438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When negative value is returned from sc_asn1_put_tag(), it is first assigned to `sbuflen`, which is unsigned, truncating the negative numbers. Only after that assigned to the `r`, causing it can't be negative, effectively hiding possible errors from the above function. Thanks coverity (CID 468028) Signed-off-by: Jakub Jelen <[email protected]>
|
Sounds like the coolkey change will need some more love. I finally found a working coolkey card and this version is crashing. |
frankmorgner
requested changes
Jun 5, 2025
The certificate is read from the CKA_VALUE, which is allocated in `data` field of `sc_pkcs15_der` structure of the `sc_pkcs15_cert_info`. This is processed, but never cleaned up. Thanks coverity (CID 454833, CID 454822) Signed-off-by: Jakub Jelen <[email protected]>
Thanks coverity (CID 13754) Signed-off-by: Jakub Jelen <[email protected]>
frankmorgner
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix recent coverity reports.
Checklist