fix deadlock when dump samples with filter #2052
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when dumping samples after applying transforms in the
onmt_build_vocab
, we may encounter a deadlock issue if thefiltertoolong
exist in the transform pipe.The multiprocessing dumping using
num_threads
queue, each corresponds to one shard of original corpus and they are supposed to be equal size. This equal size assumption will be broken by thefiltertoolong
transform as there may have a different number of examples removed from that shard which will also break the ordering when writing.To fix it, we need to pass a placeholder even that example has been filtered. Thus guaranteed the equal size assumption.