Allow empty qty-item field when creating a shipment #4828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While creating a shipment, one has to put a `0` into every order line that is out of scope for this shipment, empty values are blocked by JS, while the PHP code can take empty values without issue. This PR allows simply clearing the `qty-item` field.
github-actions
bot
added
Template : admin
|
addison74
approved these changes
Jun 20, 2025
fballiano
added a commit
to MahoCommerce/maho
that referenced
this pull request
Jun 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While creating a shipment, one has to put a
0into every order line that is out of scope for this shipment, empty values are blocked by JS, while the PHP code can take empty values without issue.This PR allows simply clearing the
qty-itemfield.Manual testing scenarios (*)