Replaced Mysql4 classes in comments

[sreichel]

Description (*)

• Replaced Mysql4 classes in comments
• moved Mage_Core_Model_Mysql4_Design_Theme_Collection (only one mysql4 class w/o resource class?)

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[sreichel]

Mhhh. dont know why this error shows up only here. These files are ignored per default and cant reproduce it locally.

[kiatng]

Mhhh. dont know why this error shows up only here. These files are ignored per default and cant reproduce it locally.

Why not skip this lib/Varien/Directory/Collection.php and see if the error goes away. That file contains a few more issues that need fixing.

[sreichel]

I already ignored this error ... https://github.com/OpenMage/magento-lts/blob/1.9.4.x/phpstan.dist.neon#L30-L32

But it does not work (only for this PR!)

[kiatng]

How about remove the file from this PR and fix it later? Would that work?

[sreichel]

It could work, but then i prefer to fix it and wait with this PR.

[fballiano]

auch, conflict

[addison74]

I am not a specialist in using PHPStan. If we take a look in browser to any PR in "Files changed" section we will see errors generated by PHPStan used by GitHub. If anyone will check them with better knowledge it will be great to fix them.

[sreichel]

@addison74 please ignore this as long it is marked as draft.

Short explain. Some Varien classes have/had had incompatible interfaces so PHPstan was not able to check them. For this reason i've ignored them PHPstan config, but this does not work for this PR for some unknown reason (autoloader ...). I'd tried to fix the incompatible interfaces and now the files are processed. The errors will be fixed in next commits.