Add name to an existing dataclip

[midigofrank]

Description

• Allow users to name existing dataclips.
• Only project editors are allowed to name dataclips.
• You can search and filter using the name

Closes #311

Validation steps

Log in as a project editor, admin, owner

1. Click to open the job panel
2. On the job panel, click Run and then choose Existing on the select box that appears
3. Choose any of the listed dataclips.
4. Just above the dataclip uuid, you'll see an input box with a placeholder Enter label
5. Type in any name, and then go back to the dataclip menu.
6. You'll notice that the name you set above is now displayed instead of the uuid.
7. In the dataclip search bar, you'll see a tag icon. Click on it.
8. Of all the listed dataclips, notice that only the ones with the names will be listed. (in our case it will only be one)

Log in as a project viewer

When logged in a viewer, you don't get access to the input box for naming a dataclip.

• If the dataclip has a name, you'll see the label, but not in an input box
• If the dataclip has no name, you won't even get to see the label row

Additional notes for the reviewer

• I have reduced the x padding of the buttons to have the fit one line when you open the inspector
• I have disabled credo warnings for the dataclip filter Enum.reduce

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

• Code generation (copilot but not intellisense)
• Learning or fact checking
• Strategy / design
• Optimisation / refactoring
• Translation / spellchecking / doc gen
• Other
• I have not used AI

You can read more details in our Responsible AI Policy

Pre-submission checklist

• I have performed a self-review of my code.
• I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
• I have updated the changelog.
• I have ticked a box in "AI usage" in this PR

[codecov]

Codecov Report

Attention: Patch coverage is 75.55556% with 11 lines in your changes missing coverage. Please review.

Project coverage is 90.01%. Comparing base (a53b139) to head (0edd1a7).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/lightning/invocation.ex	64.28%	10 Missing ⚠️
lib/lightning_web/live/workflow_live/edit.ex	90.90%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3409      +/-   ##
==========================================
+ Coverage   89.99%   90.01%   +0.01%     
==========================================
  Files         368      369       +1     
  Lines       14408    14436      +28     
==========================================
+ Hits        12967    12994      +27     
- Misses       1441     1442       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[midigofrank]

@taylordowns2000 as always, your feature breaking skills are always appreciated

[midigofrank]

@doc-han how do you rate my gpt-assisted React skills?

[taylordowns2000]

Hey @midigofrank , looking great. Started a canvas for the UI. The only big things I can see from a logic perspective are:

1. it crashes on duplicates
2. the search by name doesn't work

[error] GenServer #PID<0.6943.0> terminating
** (Ecto.ConstraintError) constraint error when attempting to update struct:

    * "dataclips_name_project_id_index" (unique_constraint)

[taylordowns2000]

all good except for vertical alignment of text and icons in the list view.

[taylordowns2000]

UI looks great!

1. please add an audit trail event for the creation and removal of a label, then i think we're good
2. please add a flash message when a label is added "Label created. Dataclip will be saved permanently."
3. please add a flash message when a label is removed "Label deleted. Dataclip will be purged when your retention policy limit is reached."

[midigofrank]

@taylordowns2000 I've added the audits and flash messages

[taylordowns2000]

This is looking great, but it seems as though the search doesn't return a named dataclip when that named dataclip is the next cron run. In this image, I'd expect "long" to match and it does. I'd also expect "here" to match, but it returns no results.

This isn't likely a big problem, as the next cron run will almost never be named/saved. But it's still strange enough to warrant some investigation. Please see if you can get it to return when searching for the name of the next cron run.

[midigofrank]

@taylordowns2000 this is likely the culprit https://github.com/OpenFn/lightning/pull/3409/files#diff-b400713bb29056407bd66ecb6e7a8663bde8d8adbf8a5a8f68f6bf3ffb8366eaR879

[midigofrank]

I have run into a situation where if the query is of base 16, like abc, the filter will only search for uuids. Because of this, I'm changing the id_prefix filter to be name_or_id_part.

[taylordowns2000]

@midigofrank , as of the last commit 0edd1a7 I'm seeing this crash when searching for either a name or a UUID:

[error] GenServer #PID<0.874.0> terminating
** (FunctionClauseError) no function clause matching in String.downcase/2
    (elixir 1.18.3) lib/string.ex:930: String.downcase(nil, :default)
    (lightning 2.13.5) lib/lightning/invocation.ex:884: anonymous fn/2 in Lightning.Invocation.dataclip_matches_filters?/2
    (elixir 1.18.3) lib/enum.ex:383: anonymous fn/3 in Enum.all?/2
    (elixir 1.18.3) lib/enum.ex:4968: Enumerable.List.reduce/3
    (elixir 1.18.3) lib/enum.ex:382: Enum.all?/2
    (lightning 2.13.5) lib/lightning/invocation.ex:838: Lightning.Invocation.list_dataclips_with_cron_state/3
    (lightning 2.13.5) lib/lightning_web/live/workflow_live/new_manual_run.ex:26: LightningWeb.WorkflowLive.NewManualRun.search_selectable_dataclips/4
    (lightning 2.13.5) lib/lightning_web/live/workflow_live/edit.ex:1533: LightningWeb.WorkflowLive.Edit.handle_event/3
    (phoenix_live_view 1.0.9) lib/phoenix_live_view/channel.ex:509: anonymous fn/3 in Phoenix.LiveView.Channel.view_handle_event/3
    (telemetry 1.3.0) /Users/taylor/OpenFn/lightning/deps/telemetry/src/telemetry.erl:324: :telemetry.span/3
    (phoenix_live_view 1.0.9) lib/phoenix_live_view/channel.ex:260: Phoenix.LiveView.Channel.handle_info/2
    (stdlib 6.2.2) gen_server.erl:2345: :gen_server.try_handle_info/3
    (stdlib 6.2.2) gen_server.erl:2433: :gen_server.handle_msg/6
    (stdlib 6.2.2) proc_lib.erl:329: :proc_lib.init_p_do_apply/3
Last message: %Phoenix.Socket.Message{topic: "lv:phx-GFQ4wxZixv9Rfj7B", event: "event", payload: %{"event" => "search-selectable-dataclips", "type" => "hook", "value" => %{"job_id" => "17a6ec8a-5812-4dfd-8a14-82861bbd0921", "limit" => 10, "search_text" => "query=funky"}}, ref: "73", join_ref: "62"}