-
Notifications
You must be signed in to change notification settings - Fork 53
feat: visualize runs on the canvas #3382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
TODO: to colour edges properly we need to resolve this: OpenFn/kit#956 |
Couple of early TODOs:
Selection doesn't work very well when we introduce many more colours like this: see #3386 Soon we'll spike out an Edit mode toggle (more comments coming in on that) |
We've encountered an issue against main which I think we can really only resolve here - sort of stubbed in in #3385 Basically what it is is: When looking at an old run / a snapshot, the snapshot should be read-only. No edits allowed. On prod right now, the We need to sort that out and ensure snapshots are read only. A wrinkle on this is that the most recent snapshot and the latest version are the same thing. So how do we differentiate? How do we make latest editable but the last run read only?? This PR might help us out. By having a History Mode and Edit Mode, as a top-level flag on the workflow diagram, we should have clearer seperation of concerns. Old runs - a workflow with an overlay - are never editable. The latest workflow (no run loaded) has no history. Use buttons in the nav bar to switch between states. |
Thoughts on showing multiple runs of the same node:
For the moment, I want to do the simplest possible thing and show show as single status and tooltip. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3382 +/- ##
==========================================
- Coverage 89.92% 89.83% -0.10%
==========================================
Files 368 368
Lines 14456 14476 +20
==========================================
+ Hits 13000 13004 +4
- Misses 1456 1472 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit f26c5ef.
This is to tell explicitly where a run started from and also whether it's a trigger node it started from
Note Situation cc: @taylordowns2000 |
I have a situation where |
Description
This PR [adds/changes/fixes]... (A description of your work goes here.)
Closes #3103
Validation steps
Additional notes for the reviewer
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner
,:admin
,:editor
,:viewer
)