-
Notifications
You must be signed in to change notification settings - Fork 53
Allow users to import workflows from base templates #3136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to import workflows from base templates #3136
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3136 +/- ##
==========================================
+ Coverage 91.52% 91.54% +0.02%
==========================================
Files 357 357
Lines 13399 13446 +47
==========================================
+ Hits 12263 12309 +46
- Misses 1136 1137 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great. i've restyled slightly and added drag & drop functionality plus some tests. thanks, frank!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@midigofrank @taylordowns2000 this is looking good to me, nice job 👏🏽
Description
This PR defines 2 templates which the user can choose from when creating a workflow, one for
webhook
trigger and another forcron
trigger.The default trigger workflow that was getting rendered initially when you create a workflow is what has been saved as base webhook template.
Closes #3110
Validation steps
Copy of {template name}
Additional notes for the reviewer
I have removed the
default workflow
from the js land that was used to load the editor. This is because currently liveview provides the templates, including the default one.AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner
,:admin
,:editor
,:viewer
)