Skip to content

add credentials with single click #3127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2025
Merged

add credentials with single click #3127

merged 3 commits into from
Apr 18, 2025

Conversation

taylordowns2000
Copy link
Member

@taylordowns2000 taylordowns2000 commented Apr 16, 2025

100% cursor. If it's fine, I'll ask it to update the tests. Wanted to see your reaction first. Single shot, so end-to-end was less than 5 min. (Very small issue, already fairly technical.)

image

https://www.loom.com/share/28d3b41a9506412d937f9ef251a65163

closes #3034

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Pre-submission checklist

  • I have performed a self-review of my code.
  • I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

@github-project-automation github-project-automation bot moved this to New Issues in v2 Apr 16, 2025
@taylordowns2000 taylordowns2000 requested a review from stuartc April 16, 2025 13:51
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.47%. Comparing base (338919e) to head (ec30d37).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3127      +/-   ##
==========================================
- Coverage   91.48%   91.47%   -0.02%     
==========================================
  Files         357      357              
  Lines       13377    13368       -9     
==========================================
- Hits        12238    12228      -10     
- Misses       1139     1140       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@taylordowns2000 taylordowns2000 marked this pull request as ready for review April 16, 2025 22:07
Copy link
Contributor

@elias-ba elias-ba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good @taylordowns2000 💯

@taylordowns2000 taylordowns2000 merged commit 2ff8ae4 into main Apr 18, 2025
8 checks passed
@taylordowns2000 taylordowns2000 deleted the cursor-3034 branch April 18, 2025 11:11
@github-project-automation github-project-automation bot moved this from New Issues to Done in v2 Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add project to credential access list without clicking "add"
2 participants