-
Notifications
You must be signed in to change notification settings - Fork 12
common: export lodash in common #1225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: epic/common-3
Are you sure you want to change the base?
Conversation
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
packages/common/src/util/lodash.js
Outdated
* @see https://lodash.com/docs/ | ||
* @module lodash | ||
* | ||
* @example <caption>Split an array into chunks of 2 items each</caption> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent 👏
@hunterachieng have you tested this in the CLI? I don't think the export is right I think you've exported it to I've also run a docs build here and What I think we need to end up with is this: Which is a bit weird isn't it? So maybe we can make it But the point is that we're exporting a namespace. We're not documenting the whole namespace here, but we do need something to click on to get to our docs. This might be a bit tricky to fix so maybe we can catch up with this on Monday. |
@josephjclark Let me try to fix it. I did use the same method we used with |
@josephjclark I have tried redoing it and exporting it away from utils. I am getting that |
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Hi @hunterachieng - I'll try and get this wrapped up for you this evening |
@hunterachieng I've created a branch
I think what we need to do is work out how to suppress the signature in the docs, and then that might be good enough? |
Summary
Export lodash in common
Fixes #831
Details
Add technical details of what you've changed (and why).
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to
know!):
You can read more details in our
Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
production? Is it safe to release?
dev only changes don't need a changeset.