-
Notifications
You must be signed in to change notification settings - Fork 12
Add util.indexOf()
function in common
#831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Wouldn't we be better off just re-exporting I think this is an idea that's been around for a long time - we just haven't gotten around to it. Actually until fairly recently I don't think we've had the technology to do it |
Yes and no, i think lodash has lots of functions exporting all of them might not be a good idea in a long run, and i am also worried about docs as well |
We wouldn't document it though, we'd just link to lodash docs and expose the |
I think I am in favour of exporting There are other toolkits available, like ramda and lodash/fp. I'd be interested in a little survey of modern utility libraries - is lodash still cool? - and a spike PR showing how this might look in code and docs (does _ count as a namespace? I don't think so, and the docsite only otherwise includes functions.... so we need to add special docs support for this?) |
Description
We are using
lodash
in some of our adaptors and most often we use one two function from the entire library.For example in
DHIS2
adaptor we only useindexOf
function from lodash. I think we can use lodash implementation of such function and turn it into a util function. For example indexOfThe text was updated successfully, but these errors were encountered: