Turn off some warnings for QoS for gcc13

[doug1234]

Note: These warnings could be due to issues with OpenDDS but turn them off for now.

[mitza-oci]

Do you have a link to the warning that this is preventing? I'll check if we can fix it in OpenDDS.

The new code is generating its own warning on compilers that don't have a -Wstringop-overflow, so this may need to be conditional on the specific compiler/version:
https://github.com/OpenDDS/OpenDDW/actions/runs/15005619676/job/42163404066?pr=42#step:24:61

[doug1234]

In static member function ‘static _Up* std::__copy_move<_IsMove, true, std::random_access_iterator_tag>::__copy_m(_Tp*, _Tp*, _Up*) [with _Tp = short int; _Up = short int; bool _IsMove = false]’,
    inlined from ‘_OI std::__copy_move_a2(_II, _II, _OI) [with bool _IsMove = false; _II = short int*; _OI = short int*]’ at /opt/rh/gcc-toolset-13/root/usr/include/c++/13/bits/stl_algobase.h:506:30,
    inlined from ‘_OI std::__copy_move_a1(_II, _II, _OI) [with bool _IsMove = false; _II = short int*; _OI = short int*]’ at /opt/rh/gcc-toolset-13/root/usr/include/c++/13/bits/stl_algobase.h:533:42,
    inlined from ‘_OI std::__copy_move_a(_II, _II, _OI) [with bool _IsMove = false; _II = short int*; _OI = short int*]’ at /opt/rh/gcc-toolset-13/root/usr/include/c++/13/bits/stl_algobase.h:540:31,
    inlined from ‘_OI std::copy(_II, _II, _OI) [with _II = short int*; _OI = short int*]’ at /opt/rh/gcc-toolset-13/root/usr/include/c++/13/bits/stl_algobase.h:633:7,
    inlined from ‘static void TAO::details::value_traits<T, dummy>::copy_range(value_type*, value_type*, iter) [with iter = short int*; T = short int; bool dummy = true]’ at /sandbox/gitlab-runner-ibst/builds/ibst/products/open-source/OpenDDW/spm-rhel9-gcc13/open-source/opendds/include/tao/Value_Traits_T.h:52:14,
    inlined from ‘static void TAO::details::value_traits<T, dummy>::copy_swap_range(value_type*, value_type*, iter) [with iter = short int*; T = short int; bool dummy = true]’ at /sandbox/gitlab-runner-ibst/builds/ibst/products/open-source/OpenDDW/spm-rhel9-gcc13/open-source/opendds/include/tao/Value_Traits_T.h:60:15,
    inlined from ‘void TAO::details::generic_sequence<T, ALLOCATION_TRAITS, ELEMENT_TRAITS>::length(CORBA::ULong) [with T = short int; ALLOCATION_TRAITS = TAO::details::unbounded_value_allocation_traits<short int, true>; ELEMENT_TRAITS = TAO::details::value_traits<short int, true>]’ at /sandbox/gitlab-runner-ibst/builds/ibst/products/open-source/OpenDDW/spm-rhel9-gcc13/open-source/opendds/include/tao/Generic_Sequence_T.h:239:36,
    inlined from ‘void TAO::details::generic_sequence<T, ALLOCATION_TRAITS, ELEMENT_TRAITS>::length(CORBA::ULong) [with T = short int; ALLOCATION_TRAITS = TAO::details::unbounded_value_allocation_traits<short int, true>; ELEMENT_TRAITS = TAO::details::value_traits<short int, true>]’ at /sandbox/gitlab-runner-ibst/builds/ibst/products/open-source/OpenDDW/spm-rhel9-gcc13/open-source/opendds/include/tao/Generic_Sequence_T.h:198:8,
    inlined from ‘void TAO::unbounded_value_sequence<T, Tag>::length(CORBA::ULong) [with T = short int; Tag = int]’ at /sandbox/gitlab-runner-ibst/builds/ibst/products/open-source/OpenDDW/spm-rhel9-gcc13/open-source/opendds/include/tao/Unbounded_Value_Sequence_T.h:60:17,
    inlined from ‘void {anonymous}::init(DDS::TopicQos&)’ at /sandbox/gitlab-runner-ibst/builds/ibst/products/open-source/OpenDDW/OpenDDW/src/qos_dictionary.cpp:54:40,
    inlined from ‘DDS::TopicQos QosDictionary::Topic::bestEffort()’ at /sandbox/gitlab-runner-ibst/builds/ibst/products/open-source/OpenDDW/OpenDDW/src/qos_dictionary.cpp:228:9:
/opt/rh/gcc-toolset-13/root/usr/include/c++/13/bits/stl_algobase.h:437:30: error: ‘void* __builtin_memmove(void*, const void*, long unsigned int)’ forming offset 2 is out of the bounds [0, 2] [-Werror=array-bounds=]
  437 |             __builtin_memmove(__result, __first, sizeof(_Tp) * _Num);
      |             ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[iguessthislldo]

If we can't fix in OpenDDS, we can check for the warning so it doesn't cause warnings in other compilers.

[iguessthislldo]

What was wrong with 65b076f? It looks correct to me and I didn't see any warnings on it.

[doug1234]

It didn't seem to work with gcc13 so it didn't fix the original problem sadly. The latest actually works.

[mitza-oci]

It didn't seem to work with gcc13 so it didn't fix the original problem sadly. The latest actually works.

Is that issue with GCC 13 visible in the CI builds on ubuntu-24.04 (GCC 13 is the default version on Ubuntu 24.04)? If not, is there a configuration change we could make in the CI?

[doug1234]

I had the issue when I built locally with gcc13. It looks like you are using gcc11 unless I am looking at the wrong thing. The CXX compiler identification is GNU 11.4.0

[mitza-oci]

I had the issue when I built locally with gcc13. It looks like you are using gcc11 unless I am looking at the wrong thing. The CXX compiler identification is GNU 11.4.0

22.04 is GCC 11; 24.04 is GCC 13

https://github.com/OpenDDS/OpenDDW/actions/runs/15076340483/job/42384505992#step:24:27

[doug1234]

Hum... I am confused then. It seems that you never got this warning with gcc13 in CI?

[iguessthislldo]

It didn't seem to work with gcc13 so it didn't fix the original problem sadly. The latest actually works.

I looked at the stackoverflow link again and discovered __has_warning is Clang only. My bad for linking something that didn't work in this situation.

[doug1234]

@iguessthislldo that makes sense but how come we are not seeing the warnings on the gcc13 build through CI. I see them when I build with gcc13 so its odd.

[mitza-oci]

I didn't see the warning in a local build with GCC 14 (I don't happen to have 13 installed on that particular VM anymore).
I may also have a different version of TAO but I think this code is essentially the same.

As far as I can tell the warning from the compiler isn't meaningful and can be ignored. That's just a theory, but if we ran an OpenDDW-using program through valgrind or asan it might help to validate.