Skip to content

[backend] Redis hostname field should not be used when using cluster mode (#6280) #10978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aHenryJard
Copy link
Member

@aHenryJard aHenryJard commented May 13, 2025

Proposed changes

  • Remove "hostname" field as mandatory on SSL configuration for cluster mode (it's "hostnames" that is mandatory in that mode)

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label May 13, 2025
@aHenryJard aHenryJard changed the title Redis hostname field whould not be used when using cluster mode [backend] Redis hostname field whould not be used when using cluster mode (#6280) May 13, 2025
Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.64%. Comparing base (8bbf3e8) to head (778694f).
Report is 44 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10978      +/-   ##
==========================================
+ Coverage   65.60%   65.64%   +0.04%     
==========================================
  Files         674      674              
  Lines       67138    67144       +6     
  Branches     7415     7421       +6     
==========================================
+ Hits        44046    44077      +31     
+ Misses      23092    23067      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aHenryJard aHenryJard changed the title [backend] Redis hostname field whould not be used when using cluster mode (#6280) [backend] Redis hostname field should not be used when using cluster mode (#6280) May 13, 2025
@aHenryJard aHenryJard marked this pull request as ready for review May 13, 2025 14:51
@aHenryJard aHenryJard marked this pull request as draft May 19, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis in cluster mode requires overlapping hostname fields
1 participant