-
Notifications
You must be signed in to change notification settings - Fork 1k
[backend] Various performance improvments #10971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10971 +/- ##
==========================================
+ Coverage 65.48% 65.61% +0.13%
==========================================
Files 674 674
Lines 67138 67182 +44
Branches 7383 7425 +42
==========================================
+ Hits 43962 44080 +118
+ Misses 23176 23102 -74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -3059,9 +3069,7 @@ const elQueryBodyBuilder = async (context, user, options) => { | |||
} | |||
} | |||
// Add standard_id if not specify to ensure ordering uniqueness |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this comment is not relevant anymore?
} else { // If not ordering criteria, order by _doc | ||
ordering.push({ _doc: 'asc' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure to understand this else
case. We are doing the same thing we did line 3072, so is it useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it could be simplified by adding ordering.push({ _doc: 'asc' });
all the time, by moving line 3072 to 3084 and removing the else condition.
Various performance improvments