Skip to content

[frontend] Saved Filters Edition (#10383) #10808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 5, 2025
Merged

Conversation

ValentinBouzinFiligran
Copy link
Member

Proposed changes

  • ListFilters reworked on TSX
  • Pill added on save icon
  • Edition mutation added

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@ValentinBouzinFiligran ValentinBouzinFiligran marked this pull request as ready for review April 24, 2025 14:16
@ValentinBouzinFiligran ValentinBouzinFiligran changed the base branch from release/current to master April 24, 2025 14:57
@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Apr 25, 2025
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 20.83333% with 19 lines in your changes missing coverage. Please review.

Project coverage is 66.15%. Comparing base (2176bb1) to head (6a9e5ec).
Report is 73 commits behind head on master.

Files with missing lines Patch % Lines
...phql/src/modules/savedFilter/savedFilter-domain.ts 15.00% 17 Missing ⚠️
...ql/src/modules/savedFilter/savedFilter-resolver.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10808      +/-   ##
==========================================
+ Coverage   65.54%   66.15%   +0.60%     
==========================================
  Files         672      673       +1     
  Lines       66977    67570     +593     
  Branches     7357     8018     +661     
==========================================
+ Hits        43900    44698     +798     
+ Misses      23077    22872     -205     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@frapuks frapuks self-requested a review April 28, 2025 07:48
@CelineSebe
Copy link
Member

tested locally. Works well👌

Copy link
Member

@frapuks frapuks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created this 2 filters in the reports page :
image

I select the second one :
image

I go in an other page (like grouping), and return to the reports page. I have my filters activated correctly. But the save button is available, and i have only the current filter into the filters list.
image

@ValentinBouzinFiligran ValentinBouzinFiligran changed the title Issue/10383 [frontend] (#10383) Apr 29, 2025
@ValentinBouzinFiligran ValentinBouzinFiligran changed the title [frontend] (#10383) [frontend] Saved Filters Edition (#10383) Apr 30, 2025
@ValentinBouzinFiligran ValentinBouzinFiligran merged commit 07b10e4 into master May 5, 2025
9 checks passed
@ValentinBouzinFiligran ValentinBouzinFiligran deleted the issue/10383 branch May 5, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants