Skip to content

[frontend] Save filters in the notifications datatable view #10288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Apr 3, 2025

Conversation

CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Mar 19, 2025

Proposed changes

  • switch notification list lines to dataTable
  • saved filters implementation

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@CelineSebe CelineSebe self-assigned this Mar 19, 2025
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.44%. Comparing base (4d9ecc5) to head (fe5ea59).
Report is 3 commits behind head on release/6.6.0.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.6.0   #10288      +/-   ##
=================================================
- Coverage          65.45%   65.44%   -0.02%     
=================================================
  Files                672      672              
  Lines              66773    66808      +35     
  Branches            7282     7292      +10     
=================================================
+ Hits               43708    43723      +15     
- Misses             23065    23085      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CelineSebe CelineSebe force-pushed the issue/6044-chunk3-notification branch from 639a948 to 38680e7 Compare March 20, 2025 16:00
@aHenryJard aHenryJard added the filigran team use to identify PR from the Filigran team label Mar 21, 2025
@CelineSebe CelineSebe force-pushed the issue/6044-chunk3-notification branch 2 times, most recently from a3ae866 to 9d01557 Compare March 27, 2025 14:13
@CelineSebe CelineSebe force-pushed the issue/6044-chunk3-notification branch from 44fcbc6 to f86f191 Compare April 2, 2025 10:05
@CelineSebe CelineSebe force-pushed the issue/6044-chunk3-notification branch from 1cc6566 to cb5d51a Compare April 2, 2025 15:31
@CelineSebe CelineSebe marked this pull request as ready for review April 2, 2025 15:53
Copy link
Member

@labo-flg labo-flg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tested after latest fixes, code LGTM

@CelineSebe CelineSebe changed the title [frontend] "Saved filters" on notifications view list [frontend] Save filters on notifications view dataTable Apr 3, 2025
@CelineSebe CelineSebe changed the title [frontend] Save filters on notifications view dataTable [frontend] Save filters in the notifications datatable view Apr 3, 2025
@CelineSebe CelineSebe merged commit c15afeb into release/6.6.0 Apr 3, 2025
6 checks passed
@CelineSebe CelineSebe deleted the issue/6044-chunk3-notification branch April 3, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants