Skip to content

[frontend] Saved filter button and create mutation (#6044) #10258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Apr 1, 2025
Merged

[frontend] Saved filter button and create mutation (#6044) #10258

merged 19 commits into from
Apr 1, 2025

Conversation

ValentinBouzinFiligran
Copy link
Member

@ValentinBouzinFiligran ValentinBouzinFiligran commented Mar 17, 2025 •
edited
Loading

Proposed changes

  • Saved Filter button after filter display area
  • dialog to add name
  • create mutation ready
  • Filters autocomplete
  • delete mutation

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@ValentinBouzinFiligran ValentinBouzinFiligran added the filigran team use to identify PR from the Filigran team label Mar 17, 2025
Base automatically changed from issue/6044 to release/6.6.0 March 18, 2025 15:24
@codecov Codecov
Copy link

codecov bot commented Mar 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/6.6.0@8feb57a). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release/6.6.0   #10258   +/-   ##
================================================
  Coverage                 ?   65.42%           
================================================
  Files                    ?      671           
  Lines                    ?    66685           
  Branches                 ?     7264           
================================================
  Hits                     ?    43628           
  Misses                   ?    23057           
  Partials                 ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ValentinBouzinFiligran ValentinBouzinFiligran marked this pull request as ready for review March 26, 2025 16:28
@Archidoit
Copy link
Member

When no filters are saved, maybe add a tooltip to indicate why the 'select saved filters' dropdown is not accessible
image

Archidoit
Archidoit reviewed Mar 27, 2025
View reviewed changes
opencti-platform/opencti-front/src/components/saved_filters/SavedFilterCreateDialog.tsx
onClose();
},
onError: () => {
onClose();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do nothing on Error? no warning at least?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the useApiMutation hook send an error message :
image

@Archidoit
Copy link
Member

'Select saved filters' is the only place where you write filterS with a 's' , maybe remove the S there and write 'filteR'
image

image

@Archidoit
Copy link
Member

The 'search' when typing a word is not working in the saved filters input
image

The input (filter2 in the screenshot below) never disappear even if I modify the filters (and they don't correspond anymore to the selected filter) --> maybe don't write anything in the input even after a saved filter selection
image

@Archidoit
Copy link
Member

If I select filter2 and then delete it, it stays in the input as selected
image

one more reason not to write the selected saved filter in the input maybe

@Archidoit
Copy link
Member

Archidoit commented Mar 27, 2025 •
edited
Loading

Don't add Saved filters in Create relationship forms... it breaks the screen

image

@CelineSebe
Copy link
Member

Tested locally 👌

@ValentinBouzinFiligran ValentinBouzinFiligran merged commit df26f94 into release/6.6.0 Apr 1, 2025
5 checks passed
@ValentinBouzinFiligran ValentinBouzinFiligran deleted the issue/6044-front branch April 1, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SouadHadjiat SouadHadjiat SouadHadjiat left review comments

@Archidoit Archidoit Archidoit left review comments

@CelineSebe CelineSebe CelineSebe approved these changes

Assignees

@CelineSebe CelineSebe

@ValentinBouzinFiligran ValentinBouzinFiligran

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ValentinBouzinFiligran @Archidoit @CelineSebe @SouadHadjiat