Skip to content

[backend] ”Saved filters” module implemented #10150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 18, 2025
Merged

Conversation

CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Mar 5, 2025

Proposed changes

  • New Saved Filter module created
  • saved filter resolver tests added

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Mar 5, 2025
@CelineSebe CelineSebe changed the base branch from master to release/6.6.0 March 5, 2025 15:21
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 91.52542% with 10 lines in your changes missing coverage. Please review.

Project coverage is 65.08%. Comparing base (2c0eb72) to head (b386c01).
Report is 30 commits behind head on release/6.6.0.

Files with missing lines Patch % Lines
...l/src/modules/savedFilter/savedFilter-converter.ts 33.33% 8 Missing ⚠️
...cti-graphql/src/modules/savedFilter/savedFilter.ts 96.96% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.6.0   #10150      +/-   ##
=================================================
+ Coverage          64.61%   65.08%   +0.46%     
=================================================
  Files                659      665       +6     
  Lines              64863    65167     +304     
  Branches            7110     7723     +613     
=================================================
+ Hits               41912    42413     +501     
+ Misses             22951    22754     -197     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ValentinBouzinFiligran ValentinBouzinFiligran marked this pull request as ready for review March 17, 2025 09:35
@CelineSebe CelineSebe changed the title [backend/frontend] ”Saved searches” on entities list view [backend] ”Saved filters” module implemented Mar 18, 2025
@CelineSebe CelineSebe merged commit 2f4f798 into release/6.6.0 Mar 18, 2025
5 checks passed
@CelineSebe CelineSebe deleted the issue/6044 branch March 18, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants