Skip to content

feat(tags): add search functionality for tags #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2025
Merged

feat(tags): add search functionality for tags #1108

merged 2 commits into from
Apr 21, 2025

Conversation

youngbeom-shin
Copy link
Member

What this PR does:

  • Add search input for tags
  • Update API to include search parameter
  • Add translations for search placeholder
    Which issue(s) this PR fixes:

Fixes # gitlab-513

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

Checklist:

  • I have added unit/e2e tests that prove your fix is effective or that this feature works.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have reviewed my own code and ensured that it follows the project's style guidelines.

Release note:

@youngbeom-shin youngbeom-shin added the GitLab linked linked to a GitLab task or issue. label Apr 21, 2025
@youngbeom-shin youngbeom-shin self-assigned this Apr 21, 2025
@youngbeom-shin
feat(tags): add search functionality for tags
28a7e0d 
- add search input for tags
- update API to include search parameter
- add translations for search placeholder
@youngbeom-shin youngbeom-shin marked this pull request as ready for review April 21, 2025 07:40
zhendi
zhendi approved these changes Apr 21, 2025
View reviewed changes
Copy link
Collaborator

@zhendi zhendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhendi zhendi merged commit b3abac9 into main Apr 21, 2025
3 checks passed
@zhendi zhendi deleted the csghub__add-serach-founctionality-for-tags branch April 21, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhendi zhendi zhendi approved these changes

@ice201508 ice201508 Awaiting requested review from ice201508 ice201508 is a code owner

@jialudev jialudev Awaiting requested review from jialudev jialudev is a code owner

@ymh6315431 ymh6315431 Awaiting requested review from ymh6315431 ymh6315431 is a code owner

@yoiteyou yoiteyou Awaiting requested review from yoiteyou yoiteyou is a code owner

@hiveer hiveer Awaiting requested review from hiveer hiveer is a code owner

Assignees

@youngbeom-shin youngbeom-shin

Labels
GitLab linked linked to a GitLab task or issue. local-verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youngbeom-shin @zhendi