Skip to content

feat(table): enhance table headers with counts #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025

Conversation

youngbeom-shin
Copy link
Member

What this PR does:

  • Added header templates to various tables
  • Displayed total counts for items in headers
  • Updated localization for count labels
    Which issue(s) this PR fixes:

Fixes # gitlab-605

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

Checklist:

  • I have added unit/e2e tests that prove your fix is effective or that this feature works.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have reviewed my own code and ensured that it follows the project's style guidelines.

Release note:


@youngbeom-shin youngbeom-shin self-assigned this Apr 18, 2025
@youngbeom-shin youngbeom-shin added the GitLab linked linked to a GitLab task or issue. label Apr 18, 2025
Copy link
Collaborator

@zhendi zhendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhendi zhendi merged commit 3e7d88f into main Apr 22, 2025
3 checks passed
@zhendi zhendi deleted the csghub__enhance-table-headers-with-counts branch April 22, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitLab linked linked to a GitLab task or issue. local-verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants