[Java] ApiClient: support deserializing from InputStream instead of String to bypass 2GB Java String limit #21115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)__
Overview
Fixes issue kubernetes-client/java#4020 .
Makes two changes:
ApiClient
, if we are deserializing JSON, get the response body as anInputStream
instead ofString
for deserialization.JSON
, add a new deserialize() method in which acceptsInputStream
.These two changes enable the
ApiClient
to bypass the 2GBString
length limit in Java and deserialize large responses greater than 2GB into Java objects.Root Cause
When the response is too large, we get an error like this:
This issue occurs because the response body is converted to a String here in the ApiClient, which hits this validation in
okhttp
:require(byteCount >= 0 && byteCount <= Integer.MAX_VALUE) { "byteCount: $byteCount" }
because of Java's String max length limit of Integer.MAX_VALUE which is 2^31 - 1.