-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added HttpClient5 flavour to Java OpenFeign client generator. #21007
base: master
Are you sure you want to change the base?
Conversation
thanks for the PR please use spaces instead of tabs for indention in the templates. |
@wing328 Yeah, sorry about that, my mistake. |
@@ -0,0 +1,9 @@ | |||
generatorName: java | |||
outputDir: samples/client/petstore/java/feign-hc5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add the new folder to the github workflow so that the CI will test the change moving forward
.github/workflows/samples-java-client-jdk11.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also regenerate the samples (step 3, run the update commands twice) and commit the new files
@wing328 Sorry (again), when I saw that Windows users specific warning I immediately thought all the text below was entirely dedicated to them, so I skipped to next check right away, lol. |
please review the CI failure when you've time |
@wing328 Looks like there is a conflict with the concomitant fixes in the crystal sample client from PR #21011: |
please use spaces instead of tabs in modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/JavaClientCodegen.java: |
Quick'n'(not-so)dirty (imho) solution to this issue:
#18158
Successfully tested with sample generated from java-feign-hc5.yaml and through Maven with plugin, with a similar configuration:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg