Skip to content

update scala-akka-http-server generator #20924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Mar 19, 2025

Scala 3.x or latest Scala 2.13.x with migrate option( -Xsource:3-cross ) require parentheses in lambda params.

Welcome to Scala 3.6.4 (11.0.26, Java OpenJDK 64-Bit Server VM).
Type in expressions for evaluation. Or try :help.
                                                                                                                                             
scala> { (x: Int) => x }
val res0: Int => Int = Lambda$1505/0x00000008007f0040@389008d1
                                                                                                                                             
scala> { x: Int => x }
-- Error: ----------------------------------------------------------------------
1 |{ x: Int => x }
  |         ^
  |         parentheses are required around the parameter of a lambda
$ scala -Xsource:3-cross
Welcome to Scala 2.13.16 -Xsource:3.0.0 (OpenJDK 64-Bit Server VM, Java 11.0.26).
Type in expressions for evaluation. Or try :help.

scala> { (x: Int) => x }
val res0: Int => Int = $Lambda$1088/0x00000008006b0840@591a4f8e

scala> { x: Int => x }
          ^
       error: parentheses are required around the parameter of a lambda
       Use '-Wconf:msg=lambda-parens:s' to silence this warning. [quickfixable]
       Scala 3 migration messages are issued as errors under -Xsource:3. Use -Wconf or @nowarn to demote them to warnings or suppress.
       Applicable -Wconf / @nowarn filters for this fatal warning: msg=<part of the message>, cat=scala3-migration

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Mar 19, 2025

did you follow step 3 to update the samples so that CI can verify the change?

cc @clasnake (2017/07), @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04) @Fish86 (2023/06)

@wing328
Copy link
Member

wing328 commented Mar 19, 2025

please also merge the latest master into your branch to fix https://github.com/OpenAPITools/openapi-generator/actions/runs/13938928568/job/39021670327?pr=20924

@wing328
Copy link
Member

wing328 commented Mar 20, 2025

thanks for the PR

if no one has question/feedback, I'll merge it later this week

@wing328 wing328 merged commit 24d2083 into OpenAPITools:master Mar 22, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants