Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elixir] Update dialyzer spec #20024

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

ntodd
Copy link
Contributor

@ntodd ntodd commented Nov 4, 2024

The spec for RequestBuilder.evaluate_response/2 does not allow for lists of structs to be returned. This is incorrect as Deserializer.to_struct/2 can return a list of structs that gets passed up through to the generated api functions.

This PR updates the RequestBuilder.evaluate_response/2 spec to correctly reflect the behavior of the function return values.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mrmstn

@wing328
Copy link
Member

wing328 commented Nov 20, 2024

thanks for the PR

if no further feedback, i'll merge it this weekend.

cc @mrmstn

@wing328 wing328 merged commit 4a6dbac into OpenAPITools:master Dec 4, 2024
16 checks passed
@wing328 wing328 added this to the 7.11.0 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants