Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVA] okhttp-gson client codegen ambiguous references for a component schema "Type" #19328

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

farnulfo
Copy link
Contributor

@farnulfo farnulfo commented Aug 8, 2024

PR to fix #19326 by removing unnecessary line "import java.lang.reflect.Type" in pojo.mustache that cause collision with a "Type" defined in a OpenAPI spec.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Try to fix issue #19326
@farnulfo farnulfo changed the title Fix issue #19326 [JAVA] okhttp-gson client codegen ambiguous references for a component schema "Type" Aug 8, 2024
@farnulfo
Copy link
Contributor Author

farnulfo commented Aug 8, 2024

Hi,

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

Here is a PR to fix #19326 but it's missing the test case: I don't know how to add it.
It's an OpenAPI file that contains a Type component that cause compilation errors with okhttp-gson generated code because of an "import java.lang.reflect.Type" in pojo.mustache template that is not necessary.

Happy to add it with your help.

@farnulfo farnulfo marked this pull request as ready for review August 8, 2024 21:26
Copy link
Contributor

@martin-mfg martin-mfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @farnulfo, thanks for the PR! I think it's fine without a dedicated test case.

@wing328 wing328 added Client: Java Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Aug 12, 2024
@wing328 wing328 added this to the 7.8.0 milestone Aug 12, 2024
@@ -13,7 +13,6 @@ import com.google.gson.stream.JsonReader;
import com.google.gson.stream.JsonWriter;
import java.io.IOException;

import java.lang.reflect.Type;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't recall the exact reason why it's added in the first place.

if this breaks any other use cases somehow, we will need to roll back this fix and use model name mapping option instead: https://github.com/openapitools/openapi-generator/blob/master/docs/customization.md#name-mapping

@wing328 wing328 merged commit d1b9f92 into OpenAPITools:master Aug 12, 2024
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client: Java Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [JAVA] okhttp-gson client codegen ambiguous references for a component schema "Type"
3 participants