Skip to content

[Ruby] Allow Overriding Accept Header #19106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

ckoegel
Copy link
Contributor

@ckoegel ckoegel commented Jul 8, 2024

The Ruby SDK currently does not allow for overriding the Accept header at runtime. The header can be set using the header_params argument when calling an operation method, but this gets overwritten by the select_header_accept method called when the data is serialized to a request. This PR adds a conditional that skips the calling of the select_header_accept method if an Accept header has been provided by the user.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)

@wing328
Copy link
Member

wing328 commented Jul 9, 2024

lgtm. thanks for the PR

@wing328 wing328 merged commit 1841f57 into OpenAPITools:master Jul 9, 2024
18 checks passed
@wing328 wing328 added this to the 7.8.0 milestone Jul 9, 2024
@ckoegel ckoegel deleted the ruby-accept branch July 9, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants