[cpp-qt-client]Allow nullable parameters #17805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you please follow step 3 to update the samples so that the CI can verify the change? cc @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08) |
MartinDelille
suggested changes
Feb 8, 2024
modules/openapi-generator/src/main/resources/cpp-qt-client/api-body.mustache
Show resolved
Hide resolved
| } | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
Why did you moved this block? It makes review harder not seeing diff properly.
There was a problem hiding this comment.
It needs the toStringValue declarated and I thought it is easier to move after them. I have not changed anything just moved the code below the toStringValue declarations.
There was a problem hiding this comment.
Ok I diffed the change and that is fine for me!
MartinDelille
approved these changes
Feb 9, 2024
| } | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
Ok I diffed the change and that is fine for me!
modules/openapi-generator/src/main/resources/cpp-qt-client/api-body.mustache
Show resolved
Hide resolved
kota65535
pushed a commit
to kota65535/openapi-generator
that referenced
this pull request
Feb 23, 2024
* [cpp-qt-client]Allow nullable parameters Fixes OpenAPITools#17756 * Update samples
oscarr-reyes
pushed a commit
to oscarr-reyes/openapi-generator
that referenced
this pull request
Feb 25, 2024
* [cpp-qt-client]Allow nullable parameters Fixes OpenAPITools#17756 * Update samples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17756
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)Summon @etherealjoy for a review as you are the author of the Qt templates.