-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Add dotnet7 workflow, new samples #17098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
You can use one workflow. The dotnet version property can be an array. https://github.com/actions/setup-dotnet `yaml
|
We did that before with java (e.g. JDK11, JDK17, etc) but later there are features only available in latest version (e.g. JDK17) so we end up splitting the workflow based on versions. |
@@ -1,4 +1,4 @@ | |||
name: Samples C# .Net 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider renaming these workflows like samples-dotnet8.yaml and then moving aspnet servers to samples-dotnet6
- samples/client/petstore/csharp/OpenAPIClient-net5.0/** | ||
# build C# API client (.net 5.0 with ConditionalSerialization) | ||
# build C# API client (.net 7.0) | ||
- samples/client/petstore/csharp/OpenAPIClient-net7.0/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In each workflow, we only need to test the samples which target that framework, so this file only needs .net 6 samples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, will do
cc @mandrean (2017/08) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) @iBicha (2023/07)
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)