-
Notifications
You must be signed in to change notification settings - Fork 48
Command prefix for a game #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Since this issue stems from the basis of umu-launcher requiring an internet connection and not being able to launch offline, I'll need to clarify that having an internet connection is only a requirement in that umu-launcher needs to fetch a 200MB+ archive at first launch. Afterwards, having an internet connection becomes not strictly required. In umu-launcher v1.2.0+, the program will not hang indefinitely when the network suddenly drops and will proceed to launch the executable. In fact, we have a test for this in our CI where it's proven launching offline is possible. Therefore, you should not need to add a command prefix. Other than that, the only other case that I'm aware of where an internet can feel like a requirement is in a network configuration where the system's wlan or eth interface are non-operational, while WireGuard interfaces are operational. In this case, umu-launcher will hang indefinitely. |
Closing as invalid and as duplicate on the basis of not being able to launch offline. Launching offline is possible other than the above exception. If you can disprove that, you'll need to list the steps to reproduce it. To launch offline and skip the update checks, you can set UMU_RUNTIME_UPDATE=0 and assign the absolute path to Proton directory to PROTONPATH which has been specified in |
That's not exactly the same issue, since I wouldn't require umu to work offline, only the game it launches. Setting UMU_RUNTIME_UPDATE would also disable runtime updates in the future (I guess that's what's it's doing besides skipping initial download). This option would be useful for convenience, since you wouldn't need to run it once with internet than again without it. And you still would get runtime updates. Would a change like this be accepted as a PR in the future? |
I do not like this, for a couple of reasons. First of all it sounds like an XY problem, you have not explained why you want to do it, or given an example, thus far. Second is that programs on the host are not visible in the runtime in their usual paths. They also won't necessarily work in the runtime, simple scripts will, things that link to system libraries have a moderate chance of failing. For now you could achieve this by using That being said, without a concrete example I don't see how this is something that umu should implement, since it complicates things unnecessarily to accommodate for limited edge-cases. I think given the alternatives, they should be explored first on a per-case basis. |
Sure I will explain my use case. I would like to prevent game's ability to 'phone home' for privacy reasons. For example games downloaded from gog.com should work offline, but you can still find cases that they try to 'phone home'. Checking every game manually would be too cumbersome, so I would like some automated way to do it.
So I'm allowing the game to only talk to gamemode over dbus and that's it. Another alternative to be implemented besides things you mentioned, would be a way to run umu-run twice (with pre-launch script in lutris or similar option), once for setting up the runtime, and second time (without internet) for launching the actual game. |
That makes sense. I would have appreciated though if you had clearly detailed your use case in your first post. While not intended for this use case specifically, I already have something that‘ll support this as a consequence and more. |
Thank you for reopening, I will remember to more clearly explain use cases in the future :) |
Hi,
I would like to run a game offline with umu (from lutris but maybe that's beside the point).
Since umu requires internet to function, I'm looking for a way to add a command prefix just before game is executed, I've tried to set PROTON_VERB to custom command, but it's validated and only few possibilities are allowed.
I'm looking for a way to inject something here:
umu-launcher/umu/umu_run.py
Lines 342 to 352 in cbe41c9
Preferably this would be a program installed on a host that is accessible to umu.
Is there a way to do such a thing? Or changes in the code are required for this?
The text was updated successfully, but these errors were encountered: