Skip to content

Improve wording on confirmation dialog #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Improve wording on confirmation dialog #74

wants to merge 1 commit into from

Conversation

ThomDietrich
Copy link

Hey,
minor detail indeed. I was always confused by the "anyway" at the end of the normal confirmation dialog. This fixes that. Feel free to further tweak the wording and/or merge directly.
Best!

@ThomDietrich ThomDietrich mentioned this pull request Oct 14, 2020
Closed
@stale
Copy link

stale bot commented Nov 13, 2020

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

@stale stale bot added the status: markedForAutoClose Issue will be closed automatically label Nov 13, 2020
@ThomDietrich
Copy link
Author

@OllisGit anything you are unsure about? Let's not have stalebot hinder improvement ;)

@stale stale bot removed the status: markedForAutoClose Issue will be closed automatically label Nov 19, 2020
@ThomDietrich
Copy link
Author

Could you add one improvement while at it?

The Spool Manager Sidebar displays my spool as:
image
The dialog however only talks about "Sunlu Black". How about we add the material info "TPU-" to it?

@stale
Copy link

stale bot commented Dec 20, 2020

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

@stale stale bot added the status: markedForAutoClose Issue will be closed automatically label Dec 20, 2020
@ThomDietrich
Copy link
Author

Not stale. Waiting for response from @OllisGit

@stale stale bot closed this Dec 31, 2020
@OllisGit OllisGit added status: inProgress I am working on it type: enhancement New feature or request and removed status: markedForAutoClose Issue will be closed automatically labels Jan 17, 2021
@OllisGit
Copy link
Owner

OllisGit commented Jan 17, 2021 •
edited
Loading

Hi @ThomDietrich,

thanks a lot for this PR, I appreciate it very much!
Will be in the next release....with the Material-Prefix.

PS. Sorry, for being late to the party, but I made a "Octoprint sabatical" (no coding, no printing) the last months.
PSS. the stale-bot is now deactivated.

@OllisGit OllisGit reopened this Jan 17, 2021
@OllisGit OllisGit added status: inNextRelease Will be implemented/fixed in next release and removed status: inProgress I am working on it labels Jan 23, 2021
@OllisGit OllisGit mentioned this pull request Jan 24, 2021
Closed
@OllisGit
Copy link
Owner

Hi @ThomDietrich,
implementation is in the latest release 1.3.0, thx again!

The improvement of the "material-output" is now tracked in this issue #102

@OllisGit OllisGit closed this Jan 24, 2021
@ThomDietrich ThomDietrich deleted the patch-1 branch January 25, 2021 10:48
@OllisGit OllisGit removed the status: inNextRelease Will be implemented/fixed in next release label May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomDietrich @OllisGit