Resolution to QR code scanning issue #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix javascript QR code selection
Fix sidebar not being updated when spool selecting by QR Code
Display the SpoolManager tab when scanning a spoolManager barcode
Perform tab switch after selectSpool to allow page to finish loading
|
This probably wants a squash commit |
VibroAxe
commented
Jan 26, 2021
| // - Open SpoolItem | ||
| self.apiClient.callSelectSpool(selectedSpoolId, function(responseData){ | ||
| //Select the SpoolManager tab | ||
| $('a[href="#tab_plugin_SpoolManager"]').tab('show') |
There was a problem hiding this comment.
@OllisGit Do you know if there Is there a better way of doing this?
Fixes OllisGit#111 using relative pathing, It might be better to do this using jinja native but I can't currently find a basepath reference
|
Also fixes #111 |
Use flask's url_for instead of hard coding
Url_for needs full class pathing
Use proper routing parsing for generateQRCode
Can't use fully qualified procedure reference as we don't know the params yet
Fix incorrect plugin path
QR code was using internal URL
|
Added some general quality of life improvements (mainly url_for), this might want to be a squash/refactored commit |
|
Thanks a lot for the PR! My fix looks similar!. |
|
@OllisGit Any chance of a version bump to pull this into 1.3.4? It's working off master but not of 1.3.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the javascript handling to fix the tab change mechanic as described in #114
Resolves absolute pathing issues from #111
General quality of life codes fixes within QR code