Skip to content

Temperature management (assign offset) #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yceoshda opened this issue Sep 7, 2020 · 11 comments
Closed

Temperature management (assign offset) #59

yceoshda opened this issue Sep 7, 2020 · 11 comments
Labels
type: enhancement New feature or request

Comments

@yceoshda
Copy link

yceoshda commented Sep 7, 2020

Hi,

This is a feature request.

Is it possible to have the temperature actually sent to the printer (like filament manager does with it's offsets) either by default, or with an option. It'll really handy to be able to slice something once and then print it with a bunch of different spools without worrying of the temperature.

Thanks

PS: Thank you for your amazing work on those plugins of yours.
@WyattNielsen
Copy link
Contributor

WyattNielsen commented Sep 9, 2020 •
edited
Loading

This is the only feature that I needed to switch from filamentManager. I took a quick initial pass at the feature and opened a draft PR to advance the conversation.

@OllisGit my biggest question in implementing this feature is the intended usage of the current temperature fields on the spool. IMO the offset is the only way to adjust a temp on a print, I see these fields as good data but an offset field in place of the temperature field could essentially give you the same data by extrapolation. I don't think you would want a temperature field and an offset field though as that seems like too much.

@stale
Copy link

stale bot commented Oct 9, 2020

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

@stale stale bot added the status: markedForAutoClose Issue will be closed automatically label Oct 9, 2020
@WyattNielsen WyattNielsen mentioned this issue Oct 12, 2020
Closed
@WyattNielsen
Copy link
Contributor

@OllisGit any thoughts on this feature? I'm willing to update the PR as needed.

@stale stale bot removed the status: markedForAutoClose Issue will be closed automatically label Oct 16, 2020
@posicat
Copy link

posicat commented Nov 12, 2020

I'm currently using Filament Manager, mostly for the temperature feature. Maybe it would help if I shared my use case.

I print mostly with PLA, and PETG, but I have a number of different filaments from different manufacturers, sometimes the bargain bin stuff I find on clearance, and some of it really nice high quality stuff. I like to customize my per-type settings in Cura, Then in Octoprint I share the database of filaments between 2 different printers (the Good one and the "experimental" one). For each filament I tweak the sweet temperature spot by adjusting the delta in filament manager up or down a few degrees.

What would be ideal for my workflow is

  1. A delta number that's added or subtracted from the temperature set in the G-code.
  2. A quick button on the GUI to get to those settings (for the filament I have selected) because I spend some time dialing it in on the printer, and then record my change in the filament manger.
  3. It'd be nice if the delta was displayed on the GUI somewhere as well.

I know other people use the tool for managing how much of a spool is left, but it looks like you've already got that handled really well! I tend to do small experimental stuff I design myself and am less concerned if I run out of filament because I'm only doing 15min-2hr prints.

I'm a software developer too, so feel free to poke at me if you need any more information, and I'm always happy to help test betas.

@newphreak
Copy link

newphreak commented Nov 29, 2020 •
edited
Loading

Is it possible to get the value from selected spool to some variable so i can use that in the octoprint start script? Even that little would be enough for me. Should be quite simple?
Edit:
Wanted variables to use:
Tool temperature
Bed temperature
Encloser temperature <- Which also should get a typo fixed, that should be enclosure? 👍

@stale
Copy link

stale bot commented Dec 29, 2020

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

@stale stale bot added the status: markedForAutoClose Issue will be closed automatically label Dec 29, 2020
@stale stale bot closed this as completed Jan 8, 2021
@OllisGit OllisGit added type: enhancement New feature or request and removed status: markedForAutoClose Issue will be closed automatically labels Jan 17, 2021
@OllisGit OllisGit changed the title Temperature management Temperature management (assign offset) Jan 17, 2021
@OllisGit OllisGit mentioned this issue Jan 17, 2021
Closed
@OllisGit
Copy link
Owner

Hi @yceoshda, @posicat,

I will take a look into the provided PR from @WyattNielsen. Take a look into the comments
#61

@newphreak I added a new issue for your request, if you have additional infos, just add it there:
#98

@OllisGit OllisGit reopened this Jan 17, 2021
@yceoshda
Copy link
Author

Hi @OllisGit,

Thank you for looking into it! Sorry I can't really be of help, I don't know Python (and unfortunately have no time to learn it properly :-( ).

@OllisGit
Copy link
Owner

Hi,
im working on the PR, but because I never used the temp-offset feature I have no clue if it is working or not, see my comment in the PR #61 (comment)

Any ideas?

@OllisGit OllisGit added status: inProgress I am working on it status: waitingForFeedback Wating for Customers feedback labels Jan 24, 2021
@OllisGit OllisGit added status: inNextRelease Will be implemented/fixed in next release and removed status: inProgress I am working on it status: waitingForFeedback Wating for Customers feedback labels May 24, 2021
OllisGit added a commit that referenced this issue May 24, 2021
@OllisGit
New Version 1.4.0
3dbd15c 
- PR #161, #117, #133, #134, #153 multi tool support. Big thanks goes to @codingcatgirl
- PR #61, #59 temperature offset. Thanks a lot @WyattNielsen

- E/B #118 use newodometer.py
- E add "implementation-api"

- B #150, #116 CSV import fixed

..other tickets
- #102, #132, #135, #140, #142
@OllisGit
Copy link
Owner

Hi,
in the latest release V1.4.0 the PR from @WyattNielsen is now included. Thanks again!!!

Please test and give me a feedback.
Olli

@OllisGit OllisGit added status: waitingForTestFeedback and removed status: inNextRelease Will be implemented/fixed in next release labels May 24, 2021
@yceoshda
Copy link
Author

Hi, haven't had the time to fully test it, but it seems to work! Thank you very (very very) much to all of you for the work on this.

@OllisGit OllisGit closed this as completed Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@newphreak @posicat @yceoshda @WyattNielsen @OllisGit